Cytoscape Wiki|
← Revision 3 as of 2005-10-01 20:27:27
Size: 372
Comment: Reformatted page so that it looks like the other comment pages.
|
← Revision 4 as of 2005-10-03 21:25:07 →
Size: 1250
Comment:
|
| Deletions are marked like this. | Additions are marked like this. |
| Line 6: | Line 6: |
|
RowanChristmas 10/03/05 - I don't like being able to have the user get direct access to Lists and Maps. It doesn't allow us to enforce, at compile time, what objects are actually going to be stored. I preferred, and this mirrors what CyData/CyDataDefinition has, is to have this class provide the List/Map methods itself, and force manipulations. Current: {{{#!java List list = new ArrayList(); list.add( new Double(5) ); list.add( new Booolean(true) ); CyAttributes.add(id, att, list ); //---> exceptions thrown }}} Rowan preferred: {{{#!java CyAttribute.addListAttributeValue( id, att, new Double(5) ); CyAttribute.addListAttributeValue( id, att, new Booloean(true) ); //----> exceptions thrown }}} There is also the question of what happens when I set a single value, then set a list....does the single value get overwritten? What about for Maps? |
Describe RFC 1/RFC1 Comment Lists here.
IlianaAvila, 9/30/05 - What do you think of using Colt (http://dsd.lbl.gov/~hoschek/colt/api/index.html) for the backend implementation of Lists? This way we don't have to convert from Double to double, Integer to integer, etc.
IlianaAvila -9/30/05- Since the methods are returning wrapper objects, ignore the comment above.
RowanChristmas 10/03/05 - I don't like being able to have the user get direct access to Lists and Maps. It doesn't allow us to enforce, at compile time, what objects are actually going to be stored. I preferred, and this mirrors what CyData/CyDataDefinition has, is to have this class provide the List/Map methods itself, and force manipulations.
Current:
1 List list = new ArrayList();
2 list.add( new Double(5) );
3 list.add( new Booolean(true) );
4
5 CyAttributes.add(id, att, list );
6 //---> exceptions thrown
7
Rowan preferred:
1 CyAttribute.addListAttributeValue( id, att, new Double(5) );
2 CyAttribute.addListAttributeValue( id, att, new Booloean(true) );
3 //----> exceptions thrown
4
There is also the question of what happens when I set a single value, then set a list....does the single value get overwritten? What about for Maps?