← Revision 1 as of 2005-10-03 21:29:08
Size: 237
Comment:
|
← Revision 2 as of 2005-10-04 14:43:18 →
Size: 884
Comment: More comments re: Event Framework
|
Deletions are marked like this. | Additions are marked like this. |
Line 1: | Line 1: |
RowanChristmas 10/03/05 -- CyData/Definition have support for events already. If we make yet another layer of events there will be 2, possibly incompatible event frameworks to use. To me this points to just extending CyData/Defintion. |
RowanChristmas - 10/03/05 -- {{{CyData/Definition}}} have support for events already. If we make yet another layer of events there will be 2, possibly incompatible event frameworks to use. To me this points to just extending {{{CyData/Defintion}}}. EthanCerami - 10/4/05 -- On the first issue, I agree that having two interfaces for listening to events is potentially very confusing, and {{{CyDataListener}}} seems to provide everything we already need. Maybe we should just stick with it, and simplify our lives. However, it is also possible that we can continue to use {{{CyDataListener}}} even if we embed {{{CyData}}} in {{{CyAttributes}}}. For example, we could set up {{{CyAttributes}}} with no separate {{{addListener()}}} methods. If a user wants to listen to events, they simple call {{{getCyData()}}}, and then register their listener with this class directly. |
RowanChristmas - 10/03/05 -- CyData/Definition have support for events already. If we make yet another layer of events there will be 2, possibly incompatible event frameworks to use. To me this points to just extending CyData/Defintion.
EthanCerami - 10/4/05 -- On the first issue, I agree that having two interfaces for listening to events is potentially very confusing, and CyDataListener seems to provide everything we already need. Maybe we should just stick with it, and simplify our lives. However, it is also possible that we can continue to use CyDataListener even if we embed CyData in CyAttributes. For example, we could set up CyAttributes with no separate addListener() methods. If a user wants to listen to events, they simple call getCyData(), and then register their listener with this class directly.